memory issues « Sparrow Forum

Sparrow Forum » Troubleshooting

memory issues

(18 posts) (5 voices)

Started 7 months ago by zahi
Latest reply from

Tags:

memory
scene

zahi
Member

hello

working on the game i noticed that menu class object that i created does not release.

To confirm this error i put a nslog in the dealloc method. and guess what it is called but still i don't see a dip in no of allocated memory.I m very sure that texture atlas is released.and i have all autorelease display objects.So what can be the problem here?i ve read somewhere that having local autorelease pools will help drain.But m not sure how to do that?

Q:i m testing in the simulator not on device.Does this matter(not enrolled yet)

Posted 7 months ago #
borrrden
Moderator

This post is a bit vague...if you are referring to instruments, make sure that you are watching "Created and still living" and not just all objects, or you will see every object that has ever been allocated. I think it defaults to all allocations, not just allocations that have not been released yet.

If your dealloc method is being called, that means that the object is being deallocated. If it fails to deallocate at that point you have some serious problems with your installation....unless you forgot to call super dealloc?

Posted 7 months ago #
zahi
Member

no.i have [super dealloc] in dealloc method.

instruments defaults to "created and living"

What installation problem?

Posted 7 months ago #
borrrden
Moderator

Are you using iOS 5?

Posted 7 months ago #
zahi
Member

no.using ios 4.3

Posted 7 months ago #
borrrden
Moderator

Hm, then I don't really have a theory. These kinds of issues are hard to track down even with all the code in front of you. Nearly impossible for others who only have this to go on...sorry.

Posted 7 months ago #
Shilo
Master Sparrow

If you share as much code as possible for your menu class, we might be of more help.

Posted 7 months ago #

zahi
Member

 
#import "Menu.h"
 
@implementation Menu 
 
- (id)init
{
    self = [super init];
    if (self) {
 
        media=[Media initializeMedia];
 
        //atlas
        menuAtlas=[[SPTextureAtlas alloc] initWithContentsOfFile:@"menu.xml"];
 
        base=[SPSprite sprite];
		base.rotation = SP_D2R(90);
		base.x = 320;
		[self addChild:base];
 
        [self loadMainPage];
 
    }
 
    return self;
}
 
-(void)loadMainPage
{
	//load mainPage and play button
    mainPageSprite=[SPSprite sprite];
    [base addChild:mainPageSprite];
 
    selectLevelDone=false;
 
	SPImage * backgroundImage=[[SPImage alloc]initWithTexture:[menuAtlas textureByName:@"mainPage"]];
	[mainPageSprite addChild:backgroundImage];
    [backgroundImage release];
 
	musicBtn=[SPSprite sprite];
	soundBtn=[SPSprite sprite];
	[mainPageSprite addChild:musicBtn];
	[mainPageSprite addChild:soundBtn];
 
	SPButton *musicBtnTemp,*soundBtnTemp;
	if(media.music)
	     musicBtnTemp=[SPButton  buttonWithUpState:[menuAtlas textureByName:@"musicBtnOn"]];
	else
		musicBtnTemp=[SPButton buttonWithUpState:[menuAtlas textureByName:@"musicBtnOff"]];
	[musicBtn addChild:musicBtnTemp];
 
	musicBtn.x=7;musicBtn.y=248;
	[musicBtnTemp addEventListener:@selector(musicBtnClicked:) atObject:self forType:SP_EVENT_TYPE_TRIGGERED];
 
	if(media.sound)
		soundBtnTemp=[SPButton buttonWithUpState:[menuAtlas textureByName:@"soundBtnOn"]];
	else
		soundBtnTemp=[SPButton  buttonWithUpState:[menuAtlas textureByName:@"soundBtnOff"]];
 
	[soundBtn addChild:soundBtnTemp];
	soundBtn.x=40;soundBtn.y=280;
	[soundBtnTemp addEventListener:@selector(soundBtnClicked:) atObject:self forType:SP_EVENT_TYPE_TRIGGERED];
 
	//play btn
	SPButton *playBtn=[SPButton buttonWithUpState:[menuAtlas textureByName:@"play"]];
	playBtn.x=184;
	playBtn.y=(320-playBtn.height)/2.0;
	[mainPageSprite addChild:playBtn];
	[playBtn addEventListener:@selector(playButtonClicked:) atObject:self forType:SP_EVENT_TYPE_TRIGGERED];
 
}
 
-(void)playButtonClicked:(SPEvent*)event
{
 
	if(selectLevelDone)
		return;
 
	selectLevelDone=TRUE;
 
    SPButton *btnTemp=(SPButton*)(event.target);
	btnTemp.enabled=NO;
    [mainPageSprite removeAllChildren];
 
    SPEvent *localEvent=[SPEvent eventWithType:EVENT_GO_TO_LEVEL_SELECT];
    [self dispatchEvent:localEvent];
 
}
 
-(void)dealloc
{
   [menuAtlas release];
 
    NSLog(@"Menu dealloc");
    [super dealloc];
}

Posted 7 months ago #

fullmoon
Member

"media=[Media initializeMedia];"
are you using the Media class? If so, don't we need to release it at some point? Just guessing^^

Posted 7 months ago #
zahi
Member

Media is just a singleton class.It is very light as its just used to store common flags like pauseFlag etc..

Posted 7 months ago #
zahi
Member

i am really sorry.Got busy with college work.Being the post creator and not being active is so bad.Now back debugging my project.

Shilo i posted menu class above. playButtonClicked method that dispatches event. Am i doing anything wrong here.

fullmoon.media class is a singleton class to store pause and level flags.its negligible when it comes to memory

Posted 6 months ago #
zahi
Member

still not able to fix it.Was trying all sort of calls

but noticed some weird stuff.it allocates roughly 5 mb for the menu class.

once adding to the stage, immediately if i remove it,all memory is deallocated.which tells me that i m releasing all allocated.
[base addChild:menu];
[base removeChild:menu];

but if i remove menu from stage as below,then it deallocates roughly 3 mb..
[[self.stage.juggler delayInvocationAtTarget:base byTime:3.0f] removeChild:currentScene];

but if i dispatch event in menu class when playButton is clicked,it does not deallocate even though menu dealloc called.

i encounter all these errors usually because i have habit if duplicating files just coz of being lazy.

menu is of subclass of spsprite.i double checked whether i have more than 1 subclass of spstage but i just have one thats the game class.

Posted 6 months ago #
zahi
Member

just for testing i started commenting each allocations,and did the reverse.

noticed that atlas is released, but images( dealloc is called) but instruments do not reflect dealloc

Posted 6 months ago #
Shilo
Master Sparrow

I actually had a (possibly) similar issue here: http://forum.sparrow-framework.org/topic/addchildimage-uses-alot-of-memory

In my approach, I was retaining the texture after removing it from the stage (instead of deallocing the texture completely), which would still take up memory for the texture, but I figure it should atleast release the memory that was used when adding the texture to the stage.

I never figured out what causes it to not release some of the memory.

Posted 6 months ago #
zahi
Member
Thank you shilo for your reply

I am sure i m not retaining any image .Let me explain what i ve done.

In stage, i have a method with following code
Menu* menu=[[Menu alloc]init]; [menu addEventListener:@selector(loadLevelSelect:) atObject:self forType:EVENT_GO_TO_LEVEL_SELECT]; [base addChild:menu]; currentScene=menu; [menu release];
loadLevelSelect just removes menu from stage

Then in main class i have a playButton and few graphics.
-(void)playButtonClicked:(SPEvent*)event { if(selectLevelDone) return; selectLevelDone=TRUE; SPButton *btnTemp=(SPButton*)(event.target); btnTemp.enabled=NO; SPEvent *localEvent=[SPEvent eventWithType:EVENT_GO_TO_LEVEL_SELECT]; [self dispatchEvent:localEvent]; }
question is am i doing dispatching right?

i created a method to test called cleanUp which does basically same thing as dealloc expect [super dealloc] (i might be extremely stupid)

so i called this cleanUp method in playButtonClicked.No,memory according to instruments is not released.I put NSlog functions in all spimage dealloc and confirms dealloc is called.

But if i call cleanUp using delayInvocation then it deallocates memory like below
[juggler delayInvocationAtTarget:self byTime:2.0f] cleanUp];
Posted 6 months ago #
Shilo
Master Sparrow

I wasn't implying that you were retaining anything. So far the code you have provided looks correct. I got no advice for you.

Posted 6 months ago #
zahi
Member

Shilo.For now am ignoring the issues.Maybe its a bug i instruments.

Posted 6 months ago #
Anonymous
Unregistered

-(void)playButtonClicked:(SPEvent*)event
{

if(selectLevelDone)
return;

selectLevelDone=TRUE;

SPButton *btnTemp=(SPButton*)(event.target);
btnTemp.enabled=NO;

SPEvent *localEvent=[SPEvent eventWithType:EVENT_GO_TO_LEVEL_SELECT];
[self dispatchEvent:localEvent];

}

Nice and perfect ...

Posted 5 months ago #

RSS feed for this topic

Reply

You must log in to post.