Sparrow Forum

1. 

   smickle
   Member

   Hi,

   I have a class of Targets, which contain their own sounds.

   The main game class, only adds the target objects.

   When i hit an object, it calls that object method to pause the sound, and start another short sound.

   This works fine for a minute, but as objects are getting removed from the main class. The sounds (i assume) are not as i reach the sound buffer limit.

   Could not allocate OpenAL buffer (ffffffff)

   So what are best practice, is there an extra step I need to perform? In addition to just removing the object from the game?

   Snippets

   Main Game Class

   -(void)monsterClickedOn:(SPTouchEvent*) event {
    
   	SPTouch *touch = [[event touchesWithTarget:self andPhase:SPTouchPhaseBegan] anyObject];
   	SPPoint *explodePosition = [touch locationInSpace:self];
    
   	if (touch)
       {
   		SPDisplayObject *currentMonster = (SPDisplayObject*)[touch target];
    
   		Monster *mmm = (Monster*)currentMonster.parent;
    
   		NSLog(@"Current Monster %@", mmm);
   		[playFieldSprite removeChild:mmm];
   		[self monsterExplosion: explodePosition];
    
   		[mmm explodePauseSound]; // pause jet sound and explode sound - wouldnt play b4 as object dont exist at certain point!
    
   		NSLog(@"X = %f, Y = %f", explodePosition.x, explodePosition.y);
    
   		[mmm removeEventListener:@selector(monsterClickedOn:) atObject:self forType:SP_EVENT_TYPE_TOUCH];
   		[self.juggler removeTweensWithTarget:mmm]; // stops rocket flying up
    
   		[playFieldSprite removeChild:mmm];
    
   	}
    
   }

   The method called in the target class

   - (void) explodePauseSound {
    
   	[jetSoundChannel pause];
   	[explodeSoundChannel play];
    
   }

   Thanks for your help

   Posted 1 year ago #
2. 

   Shilo
   Master Sparrow

   It's very hard to understand what is going on from your description and short example.

   1. Why are you removing mmm twice from the same sprite?

   Instead of:

   		NSLog(@"Current Monster %@", mmm);
   		[playFieldSprite removeChild:mmm];
   		[self monsterExplosion: explodePosition];
    
   		[mmm explodePauseSound]; // pause jet sound and explode sound - wouldnt play b4 as object dont exist at certain point!
    
   		NSLog(@"X = %f, Y = %f", explodePosition.x, explodePosition.y);
    
   		[mmm removeEventListener:@selector(monsterClickedOn:) atObject:self forType:SP_EVENT_TYPE_TOUCH];
   		[self.juggler removeTweensWithTarget:mmm]; // stops rocket flying up
    
   		[playFieldSprite removeChild:mmm];

   Try:

   		NSLog(@"Current Monster %@", mmm);
   		[self monsterExplosion: explodePosition];
    
   		[mmm explodePauseSound]; // pause jet sound and explode sound - wouldnt play b4 as object dont exist at certain point!
    
   		NSLog(@"X = %f, Y = %f", explodePosition.x, explodePosition.y);
    
   		[mmm removeEventListener:@selector(monsterClickedOn:) atObject:self forType:SP_EVENT_TYPE_TOUCH];
   		[self.juggler removeTweensWithTarget:mmm]; // stops rocket flying up
    
   		[playFieldSprite removeChild:mmm];

   I don't understand what your problem is, but it could be code that you haven't posted.

   2. Are you sure that you are retaining jetSoundChannel and explodeSoundChannel? The initializations of the sound channels should look something like this:

   SPSound *jetSound = [SPSound soundWithContentsOfFile:@"jet.caf"];
   jetSoundChannel = [[jetSound createChannel] retain];
    
   SPSound *explodeSound = [SPSound soundWithContentsOfFile:@"explode.caf"];
   explodeSoundChannel = [[explodeSound createChannel] retain];

   If you don't retain both sound channels, they will autorelease and it will cause some pretty weird problems.

   Posted 1 year ago #
3. 

   smickle
   Member

   Hi, i was playing around.. some how added the removeChild Twice.

   Here is my Target code.

    
   @interface Monster ()
    
   - (void)setupSprite;
    
   @end
    
   // --- class implementation ------------------------------------------------------------------------
    
   @implementation Monster
    
   - (id)init {
       if (self = [super init]) {
           [self setupSprite];
       }
       return self;
   }
    
   - (id)initExplosion {
       if (self = [super init]) {
           [self explodeRocket];
       }
       return self;
   }
    
   - (void)setupSprite {
    
   	SPTextureAtlas *rocketAtlas = [SPTextureAtlas atlasWithContentsOfFile:@"rocket_sheet.xml"];
   	NSArray *frames = [rocketAtlas texturesStartingWith:@"rocket_"];
   	rocket = [[SPMovieClip alloc] initWithFrames:frames fps:12];
    
   	// Sounds
   	SPSound *jetSound = [SPSound soundWithContentsOfFile:@"jet.caf"];
   	jetSoundChannel = [[jetSound createChannel] retain];
   	jetSoundChannel.loop = YES;
   	jetSoundChannel.volume = 0.1;
    
   	SPSound *explodeSound = [SPSound soundWithContentsOfFile:@"exploding.caf"];
   	explodeSoundChannel = [[explodeSound createChannel] retain];
    
   	[rocket play]; // images
    
   	[self addChild:rocket];
    
   	[self addEventListener:@selector(onAddedToStage:) atObject:self forType:SP_EVENT_TYPE_ADDED_TO_STAGE];
    
   }
    
   // once added to stage set juggler of rocket
    
   - (void)onAddedToStage: (SPEvent*) event {
    
   	NSLog(@"Added to the stage");
    
   	[self.stage.juggler addObject:rocket];
   	[jetSoundChannel play];
    
   }
    
   // Explosion
    
   - (void) explodeRocket {
    
   	SPTextureAtlas *explodeAtlas = [SPTextureAtlas atlasWithContentsOfFile:@"explode_sheet.xml"];
   	NSArray *explodeFrames = [explodeAtlas texturesStartingWith:@"instance_"];
   	rocketExplode = [[SPMovieClip alloc] initWithFrames:explodeFrames fps:18];
    
   	[rocketExplode play]; // image
    
   	[self addChild:rocketExplode];
    
   	[self addEventListener:@selector(explodeAddedToStage:) atObject:self forType:SP_EVENT_TYPE_ADDED_TO_STAGE];
    
   }
    
   - (void) explodePauseSound {
    
   	[jetSoundChannel pause]; // sound
   	[explodeSoundChannel play];
    
   }
    
   - (void) pauseSound {
    
   	[jetSoundChannel pause]; // sound
    
   }
    
   // once added to stage set juggler of rocket explosion
    
   - (void) explodeAddedToStage: (SPEvent*) event {
    
   	NSLog(@"Explode to the stage");
   	[self.stage.juggler addObject:rocketExplode];
    
   }
    
   - (void)dealloc {
       [super dealloc];
   }
    
   @end

   Main Code

   #import "Game.h" 
    
   @implementation Game
    
   - (id)initWithWidth:(float)width height:(float)height {
       if (self = [super initWithWidth:width height:height]) {
    
   		//Background images
   		SPImage *backgroundImage = [SPImage imageWithContentsOfFile:@"background.png"];
   		[self addChild:backgroundImage];
    
   		[self setUpScores];
    
   		playFieldSprite = [SPSprite sprite];
    
   		[self addChild:playFieldSprite];
    
   		[self drawMonsters]; // calls the for loop
    
       }
    
       return self;
   }
    
   -(void)setUpScores {
    
   	score = 0;
   	level = 1;
   	lives = 3;
    
   	scoreTextField = [SPTextField textFieldWithText:[NSString stringWithFormat:@"Score: %d", score]];
   	levelTextField = [SPTextField textFieldWithText:[NSString stringWithFormat:@"Level: %d", level]];
   	livesTextField = [SPTextField textFieldWithText:[NSString stringWithFormat:@"Lives: %d", lives]];
    
   	scoreTextField.fontName = @"Marker Felt";
   	scoreTextField.x = 160;
   	scoreTextField.y = 7;
   	scoreTextField.vAlign = SPVAlignTop;
   	scoreTextField.hAlign = SPHAlignRight;
   	scoreTextField.fontSize = 20;
    
   	[self addChild:scoreTextField];
    
   	levelTextField.fontName = @"Marker Felt";
   	levelTextField.x = 0;
   	levelTextField.y = 7;
   	levelTextField.vAlign = SPVAlignTop;
   	levelTextField.fontSize = 20;
    
   	[self addChild:levelTextField];
    
   	livesTextField.fontName = @"Marker Felt";
   	livesTextField.x = 90;
   	livesTextField.y = 7;
   	livesTextField.vAlign = SPVAlignTop;
   	livesTextField.fontSize = 20;
    
   	[self addChild:livesTextField];
    
   }
    
   -(void)drawMonsters {
    
   	for(int i = 0; i < level + 3; i++)
   	{
   		printf("executing");
   		[self addMonster];
   	}
   }
    
   -(void)addMonster {
    
   	myMonster = [[Monster alloc]init];
    
   	myMonster.x = (arc4random() % (int)(self.width - myMonster.width)); // where it begins on x axis
   	myMonster.y = self.height + (arc4random() % 100); // starts at different times
    
   	NSLog(@"Starting Y postition: %f", myMonster.y);
    
   	SPTween *tween = [SPTween tweenWithTarget:myMonster
   										 time: arc4random() % 10 + 5 // 5 - 15 range time
   								   transition:SP_TRANSITION_LINEAR];
    
   	[tween animateProperty:@"x" targetValue:arc4random() % (int)(self.width - myMonster.width)]; // final x postition
    
   	[tween animateProperty:@"y" targetValue: -myMonster.height * 2];
    
   	[self.juggler addObject:tween];
    
   	[playFieldSprite addChild:myMonster];
    
   	[myMonster addEventListener:@selector(monsterClickedOn:) atObject:self forType:SP_EVENT_TYPE_TOUCH];
    
   	[tween addEventListener:@selector(movementThroughTopOfScreen:) atObject:self forType:SP_EVENT_TYPE_TWEEN_COMPLETED];
    
   }
    
   -(void)monsterClickedOn:(SPTouchEvent*) event {
    
   	SPTouch *touch = [[event touchesWithTarget:self andPhase:SPTouchPhaseBegan] anyObject];
   	SPPoint *explodePosition = [touch locationInSpace:self];
    
   	if (touch)
       {
   		SPDisplayObject *currentMonster = (SPDisplayObject*)[touch target];
    
   		Monster *mmm = (Monster*)currentMonster.parent;
    
   		NSLog(@"Current Monster %@", mmm);
   		[self monsterExplosion: explodePosition];
    
   		[mmm explodePauseSound]; // pause jet sound and explode sound - wouldnt play b4 as object dont exist at certain point!
    
   		NSLog(@"X = %f, Y = %f", explodePosition.x, explodePosition.y);
    
   		[mmm removeEventListener:@selector(monsterClickedOn:) atObject:self forType:SP_EVENT_TYPE_TOUCH];
   		[self.juggler removeTweensWithTarget:mmm]; // stops rocket flying up
    
   		[playFieldSprite removeChild:mmm];
   	}
    
   }
    
   - (void) monsterExplosion: (SPPoint*) event {
    
   	NSLog(@"X = %f, Y = %f", event.x, event.y);
    
   	explosion = [[Monster alloc]initExplosion];
    
   	explosion.x = event.x;
   	explosion.y = event.y;
    
   	[playFieldSprite addChild:explosion];
    
   	SPTween *tween = [SPTween tweenWithTarget:explosion
   										 time:0.5
   								   transition:SP_TRANSITION_EASE_IN];
    
   	[tween animateProperty:@"y" targetValue: event.y + 20];
    
   	[self.juggler addObject:tween]; //down falling tween
    
   	[tween addEventListener:@selector(endExplosion:) atObject:self forType:SP_EVENT_TYPE_TWEEN_COMPLETED];
    
   	score = score + 10;
   	scoreTextField.text = [NSString stringWithFormat:@"Score: %d", score];
   }
    
   -(void)endExplosion:(SPEvent*)event {
    
   	NSLog(@"Rocket down. Current Rockets = %d", playFieldSprite.numChildren);
    
   	SPTween *animation = (SPTween*)[event target];
   	SPDisplayObject *currentRocket = (SPDisplayObject*)[animation target];
   	[playFieldSprite removeChild:currentRocket];
    
   	NSLog(@"Rocket Count = %d", (playFieldSprite.numChildren)); 
    
   	if(playFieldSprite.numChildren == 0) // level set up
   	{
   		level++;
   		levelTextField.text = [NSString stringWithFormat:@"Level: %d", level];
   		[self drawMonsters];
   	}
    
   }
    
   -(void)movementThroughTopOfScreen:(SPEvent*)event {
    
   	NSLog(@"Gone and stopped. Current Children = %d", playFieldSprite.numChildren);
    
   	SPTween *animation = (SPTween*)[event target];
   	NSLog(@"animation %@", animation);
   	Monster *currentMonster = (Monster*)[animation target];
   	NSLog(@"Current Monster %@", currentMonster);
   	[playFieldSprite removeChild:currentMonster];
   	[currentMonster pauseSound];
   	NSLog(@"%d", playFieldSprite.numChildren);
    
   	if (lives > 0) {
   		lives = lives - 1;
   	}
    
   	livesTextField.text = [NSString stringWithFormat:@"Lives: %d", lives];
    
   	if(playFieldSprite.numChildren == 0 && lives > 0) // level set up
   	{
   		level++;
   		levelTextField.text = [NSString stringWithFormat:@"Level: %d", level];
   		[self drawMonsters];
   	}
    
   	if(lives <= 0 && resetButtonVisible == NO)
   	{
    
   		for (int x = 0; x < playFieldSprite.numChildren ; x++) {
   			Monster *cycleRemove = (Monster*)[playFieldSprite childAtIndex:x];
   			NSLog(@"Left on screen %@", cycleRemove);
   			[cycleRemove pauseSound];
   		}
    
   		resetButtonVisible = YES;
    
   		[self.juggler removeAllObjects];
    
   		SPImage *backgroundImage = [SPImage imageWithContentsOfFile:@"screenoverlay.png"];
   		[playFieldSprite addChild:backgroundImage];
    
   		SPButton *resetButton = [SPButton buttonWithUpState:[SPTexture textureWithContentsOfFile:@"reset_button.png"]];
   		resetButton.x = self.width / 2 - resetButton.width/2;
   		resetButton.y = self.height/ 2 - resetButton.height/2;
   		resetButton.fontName = @"Marker Felt";
   		resetButton.fontSize = 20;
   		resetButton.text = @"Try Again";
    
   		[resetButton addEventListener:@selector(onResetButtonTriggered:) atObject:self forType:SP_EVENT_TYPE_TRIGGERED];
    
   		[playFieldSprite addChild:resetButton];
    
   	}
   }
    
   - (void)onResetButtonTriggered:(SPEvent*)event
   {
   	[playFieldSprite removeAllChildren];
    
   	resetButtonVisible = NO;
    
   	level = 1;
   	score = 0;
   	lives = 3;
   	levelTextField.text = [NSString stringWithFormat:@"Level: %d", level];
   	scoreTextField.text = [NSString stringWithFormat:@"Score: %d", score];
    
   	[self drawMonsters];
   }
    
   -(void) dealloc {
    
   	[super dealloc];
   	[myMonster release];
   	[explosion release];
   }
    
   @end

   Thanks...

   Posted 1 year ago #
4. 

   Shilo
   Master Sparrow

   Sorry, don't have time to look it over tonight. I'm sure someone will help you by the time I wake up, if not, ill have a look at it.

   Maybe this will be useful: http://forum.sparrow-framework.org/topic/openal-issue

   Posted 1 year ago #
5. 

   smickle
   Member

   Thanks mate. The game runs fine, just when i hit level 5/6 onwards .. the sounds mess up and i get that error code i stated in the first post.

   The game continues to run smooth - just not the sounds, they dont play / delayed etc.

   That why i thought i needed to do something extra, other than just remove the sprite.

   Posted 1 year ago #
6. 

   Shilo
   Master Sparrow

   From a quick glance, I notice some memory leaks. You also need to make sure to release your Monster instances when you are done with them. Inside your dealloc, you can release your sound channels, which will fix your source limit issue. I suggest you run the memory leak performance tool on your game and step though all of the leaks.

   Just a quick suggestion, since I don't see you using the global instance of "myMonster" other then initialization, i suggest you make it a local variable and release it.

   Example:

   -(void)addMonster {
    
   	Monster *myMonster = [[Monster alloc] init]; // <------
    
   	myMonster.x = (arc4random() % (int)(self.width - myMonster.width)); // where it begins on x axis
   	myMonster.y = self.height + (arc4random() % 100); // starts at different times
    
   	NSLog(@"Starting Y postition: %f", myMonster.y);
    
   	SPTween *tween = [SPTween tweenWithTarget:myMonster
   										 time: arc4random() % 10 + 5 // 5 - 15 range time
   								   transition:SP_TRANSITION_LINEAR];
    
   	[tween animateProperty:@"x" targetValue:arc4random() % (int)(self.width - myMonster.width)]; // final x postition
    
   	[tween animateProperty:@"y" targetValue: -myMonster.height * 2];
    
   	[self.juggler addObject:tween];
    
   	[playFieldSprite addChild:myMonster];
    
   	[myMonster addEventListener:@selector(monsterClickedOn:) atObject:self forType:SP_EVENT_TYPE_TOUCH];
    
   	[tween addEventListener:@selector(movementThroughTopOfScreen:) atObject:self forType:SP_EVENT_TYPE_TWEEN_COMPLETED];
    
           [myMonster release]; // <------
           //release the sound channels and such inside the - (void)dealloc of Monster.
   }

   Shame on me for staying up late again!

   Goodnight and goodluck!

   Posted 1 year ago #
7. 

   smickle
   Member

   Thank you Shilo!

   Those 2 simple memory management things you suggested did the trick!
   [jetSoundChannel release];
   [explodeSoundChannel release];

   I target Class and also the local monster creation and release.

   I'm rusty on that area that for sure!

   On a side note,

   if (touch) {
    
   		SPDisplayObject *currentMonster = (SPDisplayObject*)[touch target];
    
   		Monster *mmm = (Monster*)currentMonster.parent;
   }

   is there a better way than above. It looks messy.

   I do it only because, if I call a method on currentMonster, I get a warning saying it wont respond. So i turn it into mmm...

   Thanks again,

   Your a Guru!

   Posted 1 year ago #
8. 

   Shilo
   Master Sparrow

   You get that warning because you are casting it as a SPDisplayObject instead of a Monster class.

   Try:

   Monster *currentMonster = (Monster *)[touch target];

   I'm not sure why you are trying to access the parent of the target either.

   I assume:
   target = myMonster (Monster)
   target.parent = playFieldSprite (SPSprite)

   I doubt your current code with "mmm" works, since it is playFieldSprite.

   Just cast currentMonster as (Monster *) and work with that instead, and all should be fine.

   *rubs eyes*

   Posted 1 year ago #
9. 

   smickle
   Member

   Hi

   I thought it would work like you suggest, but it doesnt, so I played around and this worked. But yeah, it looks messy.

   I again tried your suggestion

   Monster *currentMonster = (Monster *)[touch target]

   It crashes with...

   -[SPMovieClip explodePauseSound]: unrecognized selector sent to instance

   -(void)monsterClickedOn:(SPTouchEvent*) event {
    
   	SPTouch *touch = [[event touchesWithTarget:self andPhase:SPTouchPhaseBegan] anyObject];
   	SPPoint *explodePosition = [touch locationInSpace:self];
    
   	if (touch)
       {
   		SPDisplayObject *currentMonster = (SPDisplayObject*)[touch target];
   		NSLog(@"Current Monster object is %@", currentMonster); // returns <SPMovieClip>
    
   		Monster *mmm = (Monster*)currentMonster.parent; // returns <Monster>
   		NSLog(@"mmm  object is %@", mmm);
    
   		//Monster *mmm = (Monster*)[touch target]; // -[SPMovieClip explodePauseSound]: unrecognized selector sent to instance
    
   		NSLog(@"Current Monster %@", mmm);
   		[playFieldSprite removeChild:mmm];
   		[self monsterExplosion: explodePosition];
    
   		[mmm explodePauseSound]; // pause jet sound and explode sound - wouldnt play b4 as object dont exist at certain point!
    
   		NSLog(@"X = %f, Y = %f", explodePosition.x, explodePosition.y);
    
   		[mmm removeEventListener:@selector(monsterClickedOn:) atObject:self forType:SP_EVENT_TYPE_TOUCH];
   		[self.juggler removeTweensWithTarget:mmm]; // stops rocket flying up
    
   	}
    
   }

   I dont understand why it crashes using the method you suggest. For some reason the object stored in mmm is not of type monster.

   But when i do it my way, it does!

   I dont get it!

   Posted 1 year ago #
10. 

    Shilo
    Master Sparrow

    I see, guess I was wrong then. If your method works then it works.

    Posted 1 year ago #
11. 

    smickle
    Member

    Yeah it works, but there must be a better way.

    Cheers!

    Posted 1 year ago #
12. 

    baike
    Moderator

    I think it's because this line:

    SPTouch *touch = [[event touchesWithTarget:self andPhase:SPTouchPhaseBegan] anyObject];

    Is drawing from the set of all touched objects in the container. So it's picking up the rocket movieclip which is a child of the Monster that you actually want to access. My Sparrow-fu is a bit rusty, but I think you're better off just using the event target directly:

    Monster *m = (Monster *)event.target;

    Posted 1 year ago #
13. 

    Shilo
    Master Sparrow

    Thank you Baike! I confused SPEvent.target with SPTouch.target. That makes perfect since that the current method would return the top-most object (rocket).

    @smickle, Baike is correct, event.target would work fine.

    Posted 1 year ago #
14. 

    smickle
    Member

    No luck...tried

    Monster *m = (Monster *)event.target;

    and

    Monster *m = (Monster *)[event target];

    2011-03-24 09:30:40.291 SpaceTap[302:207] Starting Y postition: 544.000000
    2011-03-24 09:30:40.294 SpaceTap[302:207] Added to the stage
    2011-03-24 09:30:42.730 SpaceTap[302:207] mmm object is <SPMovieClip: 0x5687270>
    2011-03-24 09:30:42.730 SpaceTap[302:207] Current Monster <SPMovieClip: 0x5687270>
    2011-03-24 09:30:42.731 SpaceTap[302:207] X = 252.000000, Y = 401.000000
    2011-03-24 09:30:42.734 SpaceTap[302:207] Explode to the stage
    2011-03-24 09:30:42.734 SpaceTap[302:207] -[SPMovieClip explodePauseSound]: unrecognized selector sent to instance 0x5687270
    2011-03-24 09:30:42.736 SpaceTap[302:207] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[SPMovieClip explodePauseSound]:

    Both cause a crash! They both are still returning a SPMovieClip and when I send the explodePauseSound sound, crash.

    As Bailke suggested, maybe i need to alter

    SPTouch *touch = [[event touchesWithTarget:self andPhase:SPTouchPhaseBegan] anyObject];

    this line some how as well.

    Thanks

    Posted 1 year ago #
15. 

    Shilo
    Master Sparrow

    Try "event.currentTarget", if that doesn't work, I don't know what to say. There's no reason not to use your previous method if it works.

    I feel like i'm the blind leading the blind.

    Posted 1 year ago #
16. 

    smickle
    Member

    JACKPOT

    Shilo does it again!

    Monster *mmm = (Monster*)event.currentTarget;

    This returns the monster object as required.

    Thanks again!

    Posted 1 year ago #

RSS feed for this topic

Reply

You must log in to post.