SPTouchEvent to deallocate instance

jbernabeu

Hello,

This is my first topic. I've looking in the forum for answers but I have not find any solution for this issue.

I have enabled multiTouch and I noticed taht when I push two objects, then I leave one and the action is to delete all the objects and remove the listener, as soon as I leave the other object I get an error like this one:

*** -[SPQuad stage]: message sent to deallocated instance 0x18fe0500

and it is in the line 85 from SPTouchProcessor.m:

if (!existingTouch.target.stage)

How could I do it?

Thanks in advance.

Shilo

What version of Sparrow are you using?

Is it Sparrow or Sparrow-S?

If it's Sparrow, not Sparrow-S:

Is it a version older than Sparrow 2.0? (Sparrow 1.4, ect)
Is it the official zip download of Sparrow 2.0?
Is it the official zip download of Sparrow 2.0.1?
Is it the latest version in the github Master branch?
Is it the latest version in the github Stable branch? (I assume that'd be the same as the official zip download of Sparrow 2.0.1)
If other, please describe.
Another question: Is your project itself, using ARC or MRC?

The reason I ask this, is because this crash could be due to the switch from ARC to MRC, which I haven't tested yet because I still am using Sparrow 2.0.

In more detail, I assume the crash is due to the SPQuad being released from the memory, but (SPTouch instance).target is never nilled, which would cause a bad access crash when attempting to reference the target.

Since I still have Sparrow 2.0 and I am not sure what version you have, I can't confirm where the bug is, but I assume you can prevent the crash by changing your design structure a bit. May I see the full code in the touch event method?

jbernabeu

Hi Shilo,

thanks in advance. First of all I will try to answer your questions:

I am using the latest version in the github Master branch. I have probed again with the framework before it was translated to MRC and it works perfect.

I founded that some other got the same problem.

https://github.com/Gamua/Sparrow-Framework/issues/16

My project is using ARC.

Yes, you are right, the problem is because I released a SPQuad and after that Sparrow tries to deliver a SPTouchEvent to that target. I don't know if its possible to destroy all events to one target in any way so I could destroy them before I release the object.

My touch event method is this:

-(void) onClick:(SPTouchEvent*)event
{
    SPTouch *touchUp = [[event touchesWithTarget:self andPhase:SPTouchPhaseEnded]
                        anyObject];

    if (!_swipeReconocido && touchUp)
    {
        [self releaseThisObject];
    }
} 

- (void) releaseThisObject
{
    if (_webView)
        [_webView removeFromSuperview];

    if (Sparrow.currentController.view)
        [Sparrow.currentController.view removeGestureRecognizer:_swipe];

    [_swipe removeTarget:self action:@selector(handleViewsSwipe:)];

    [_volver removeEventListener:@selector(onClickVolver:) atObject:self forType:SP_EVENT_TYPE_TOUCH];
    [self removeEventListener:@selector (onClick:) atObject:self forType:SP_EVENT_TYPE_TOUCH];

    for (int i=self.numChildren-1; i>0; --i)
    {
        SPDisplayObject *objeto = [self childAtIndex:i];
        objeto.touchable = NO;
        [Sparrow.juggler removeObjectsWithTarget:objeto];
        if ([objeto isKindOfClass:[SPSprite class]])
        {
            [self liberaObjetosSprite:(SPSprite *)objeto];
        }

    }

    [self removeAllChildren];
    [self.parent removeChild:self];
}

racarone

Shilo is correct. Since zeroing weak references don't exist in MRC SPTouch should be retaining its target.

Daniel

Thanks for the report! I just added the fix to the master branch. It should be fixed once you pull the latest version.

jbernabeu

Thanks !!!!!!!