Strange problem on iPhone 6+

asmodannt

Hi,
I just found a strange problem with aifc sounds on iPhone 6+.
On iPhone 6+ they are not playing for me.
I started to look at Sparrow code and found that fullPath for that sound is always nil.
Check out the code of SPAVSound:

@implementation SPAVSound
...
- (instancetype)initWithContentsOfFile:(NSString *)path duration:(double)duration
{
    if ((self = [super init]))
    {
        NSString *fullPath = [SPUtils absolutePathToFile:path];
        NSLog(@"\n\npath = %@ \nfullPath = %@ \n\n", path, fullPath); // Added NSlog to watch path and fullPath values
        _soundData = [[NSData alloc] initWithContentsOfMappedFile:fullPath];
        _duration = duration;
    }
    return self;
}

Here is the output for any device (except iPhone 6+):

2014-11-25 11:56:46.316 TestApp[54254:3191906]

path = /Users/a.dudanovskis/Library/Developer/CoreSimulator/Devices/5DD291B9-967B-407D-9C00-6CD47F058650/data/Containers/Bundle/Application/9DD541BC-E28C-4B0B-8669-AC89E2B58781/TestApp.app/gameMusic.aifc
fullPath = /Users/a.dudanovskis/Library/Developer/CoreSimulator/Devices/5DD291B9-967B-407D-9C00-6CD47F058650/data/Containers/Bundle/Application/9DD541BC-E28C-4B0B-8669-AC89E2B58781/TestApp.app/gameMusic.aifc

And here is the output for iPhone 6+:

2014-11-25 12:09:34.398 TestApp[54416:3198211]

path = /Users/a.dudanovskis/Library/Developer/CoreSimulator/Devices/C86EA297-EDC3-4237-91F1-0F6E2A79BAC5/data/Containers/Bundle/Application/BEFA639E-A655-4858-A80E-D70FE8EE7763/TestApp.app/gameMusic.aifc
fullPath = (null)

I couldn't understand why it happening only for iPhone 6+ (on simulator and on real device), but on any other devices with any iOS versions it is working fine.

Obviously the problem is in the [SPUtils absolutePathToFile:path] method, but I couldn't understand where exactly.

I added one line of code after the full path creation and this fixed my problem.
Here is that line:

fullPath = (fullPath) ? fullPath : path;

So have any of you faced the same problem or only me?
Maybe you have any thoughts about this?

Shilo

Just a complete guess with no testing.
I assume it's line 92 (the return line):

else if (factor >= 2.0f)
        return [SPUtils absolutePathToFile:originalPath withScaleFactor:factor/2.0f idiom:idiom];

I assume the factor is > 2.0f if you are truely supporting iPhone 6 (and 6+) resolution. Normally the factor would be == to 2.0f if you are not natively supporting iPhone 6 (and 6+) resolution. I think a fix would be one of the following:

else if (factor >= 2.0f)
        return [SPUtils absolutePathToFile:originalPath withScaleFactor:factor/factor idiom:idiom];

Or better yet, just setting the scale factor to 1.0f directly:

else if (factor >= 2.0f)
        return [SPUtils absolutePathToFile:originalPath withScaleFactor:1.0f idiom:idiom];

On that note, I think it's kind of pointless for the system to even check for a @scale_factor suffix for certain files like audio. Both of the fixes should not effect the other scale factors negatively.

I am sure you can track down the issue with a breakpoint in the method and debugging line by line.

asmodannt

Yes, it is possible, but I didn't spend a lot of time to find the correct solution.
Strange is that other sounds (*.caf) are working fine and it happens only for aifc files.
I didn't try any other audio formats.

Daniel

The fix is actually this:

else if (factor >= 2.0f)
    return [SPUtils absolutePathToFile:originalPath withScaleFactor:factor-1.0f idiom:idiom];

And it's already part of the development version! I recommend you update to that one.
Maybe I should add an intermediate release with that fix; as you can imagine, the same problem will pop up for textures.

In fact, the version of Sparrow you're using was released before the "6 plus" was revealed, so I'm actually rather happy that only this one change was necessary to fully support it. 😉

Shilo

Just revisited this topic to fix the same problem in one of our frameworks. Although I could have fixed it without reviewing this topic, it was still nice to read it again.

theyonibomber

Just had the exact same problem.
Maybe it's time to get the fix out of development?

BTW, Why does SPAVSound.m use SPUtil absolutePathToFile that is optimized for image assets? Seems a bit of a waste to me to try all kinds of idioms and scaleFactors for sounds...

Daniel

Yeah, that the sound class checks for "@2x" (etc.) is a little oddity, that should definitely be changed. 😉

And yes, it would be high time for an updated version that adds these (and more) fixes. Sorry that it's been so long ... but currently, I must admit it's hard to motivate me to work on Sparrow, since I'm not doing any native iOS development ... 😐