Sparrow no longer supporting devices running iOS 7.0?

aowenb

After updating from Sparrow 2.0.1 to Sparrow 2.2, I noticed my app crashing on devices running iOS 7.0 due to unsupported code in Sparrow, such as: matrix_identity_float4x4 (which requires iOS 8.0) and [NSString containsString] which does not exist in iOS 7.0.

Is the idea to only support devices running the latest version of iOS?

jdraymon

Usual rule of thumb for iOS is 2 releases- in this case 8 and 9

aowenb

Thanks, yes I guess we are being a bit generous in supporting 7.0.

Either way, it might be a good idea to update the minimum deployment target to iOS 8.0 in the Sparrow project file, as this could catch a few people out that are still targeting older iOS versions.

niksan

Losing a generation for two functions is a bit meh to be honest, if there was a lot of refactoring fair enough.

aowenb

True, it is easy to fix by hacking Sparrow, but the issue is in not knowing what the supported iOS version is.

For example someone may have a minimum requirement of iOS 8.0 for their app, but Sparrow silently only supports version 9.0.

Unless they test on a device with 8.0, then they could release a product that would crash on end user devices.

I agree that it is absolutely our responsibility to check those devices, but it would be helpful to know in advance - especially if that would involve just a minor update to the Sparrow project file that specified the correct minimum iOS version.

Sorry I don't mean for this to sound in any way negative, Sparrow is a fantastic framework that we rely on heavily, and which personally am a huge fan of. I am just trying to help people who may come across this issue.

niksan

Sorry, my point was that the two changes didn't need to happen in the first place as there's little to no gain and a bigger loss.

racarone

This was just an oversight, Sparrow is currently intended to support iOS 7. I've updated the master to include 7.0 compatible versions of the missing code. Let me know if there's any other problems!

aowenb

Thank you Rob, this works fine now.

aowenb

Actually Rob, I'm not sure your matrix fix is correct...

#if __IPHONE_OS_VERSION_MAX_ALLOWED < 80000
static const matrix_float4x4 matrix_identity_float4x4 = (matrix_identity_float4x4) {
    1, 0, 0, 0,
    0, 1, 0, 0,
    0, 0, 1, 0,
    0, 0, 0, 1
};
#endif

Should it not be __IPHONE_OS_VERSION_MIN_ALLOWED and cast to matrix_float4x4 ...ie:

#if __IPHONE_OS_VERSION_MIN_ALLOWED < 80000
static const matrix_float4x4 matrix_identity_float4x4 = (matrix_float4x4) {
    1, 0, 0, 0,
    0, 1, 0, 0,
    0, 0, 1, 0,
    0, 0, 0, 1
};
#endif

Though even this fails to compile for me due to matrix_identity_float4x4 having being previously defined in matrix.h

racarone

Sorry! You're right, I didn't take the time to test it. I'll fix it later today!

racarone

I just replaced these under different names, should work now.

aowenb

Thanks Rob, though I think you may have missed a few:

SPNSExtensions.m

#if __IPHONE_OS_VERSION_MAX_ALLOWED < 80000

Should be MIN_ALLOWED

SPMatrix.m

- (SPMatrix3D *)convertTo3D
{
    matrix_float4x4 matrix = matrix_identity_float4x4;

Need to use the identity matrix you added in SPMatrix3D here

SPContext.m

_nativeContext.multiThreaded

This is not available on 7.0 - it was introduced in 7.1

racarone

Ok, I finally just downloaded Xcode 6.4 and corrected all these errors. This should be all of them, but let me know if I've missed any,

aowenb

Yes, that works great now Rob! Thanks for the quick response.